Re: [PATCH] staging: greybus: audio_manager: Add newline to sysfs output

From: Dan Carpenter

Date: Thu Oct 29 2026 - 14:56:01 EST


On Thu, Oct 29, 2026 at 11:19:40PM +0500, Maria Sheikh wrote:
> Fix checkpatch warning:
>
> WARNING: return sysfs_emit(. . .) formats should include a terminating
> newline.
>
> Add "\n" to the sysfs_emit() format strings of the name, vid, pid,
> intf_id, ip_devices and op_devices attributes.
>
> Signed-off-by: Maria Sheikh <mariasheikh812@xxxxxxxxx>

This changes how the sysfs file appears to the user and potentially
breaks a script or something. You can't do it without testing.

regards,
dan carpenter