Re: [PATCH 4/4] drm/panel: newvision-nv3051d: Use mipi_dsi_*_multi(); fix minor bugs

[Doug Anderson]

Hi,

On Mon, Oct 12, 2026 at 9:36 PM Akash Sukhavasi
<akash.sukhavasi@xxxxxxxxx> wrote:
>
> @@ -274,6 +269,7 @@ static int panel_nv3051d_prepare(struct drm_panel *panel)
>  {
>         struct panel_nv3051d *ctx = panel_to_panelnv3051d(panel);
>         struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
> +       struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
>         int ret;
>
>         dev_dbg(ctx->dev, "Resetting the panel\n");
> @@ -295,22 +291,16 @@ static int panel_nv3051d_prepare(struct drm_panel *panel)
>                 goto disable_vdd;
>         }
>
> -       ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
> -       if (ret < 0) {
> -               dev_err(ctx->dev, "Failed to exit sleep mode: %d\n", ret);
> -               goto disable_vdd;
> -       }

Similar to patch #3, I would have passed the ctx to the init function.
That would have also fixed the pre-existing bug that Sashiko found. I
guess it's OK to fix it in a follow-up patch, though.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>