Re: [PATCH net-next v2] netdevsim: reject port addition and clean up ports after a failed reload

[Mina Almasry]

On Fri, Oct 30, 2026 at 2:05 AM Hangbin Liu <hangbin.liu@xxxxxxxxx> wrote:
>
> Looks Joas has a same issue fix with yours a few hour earlier.
>
> https://lore.kernel.org/netdev/179324296598.34505.11070163314749859668@xxxxxxxxx/
>
> > ---
> > Tested with syzbot C reproducer.
> > v2: drop Cc:stable and target net-next.
...
> But yours have an extra guard in nsim_drv_port_add...
>
> Leave this to Jakub decide...

I prefer Ömer's version. Once reload_down has torn down the device and
reload_up has failed, the device is in an uninitialized state, so
rejecting new_port in nsim_drv_port_add() makes more sense than
allowing ports/netdevs to be registered on a half-torn-down nsim_dev
and only cleaning them up later.

-- 
Thanks,
Mina