Re: [PATCH] wifi: ath10k: Drop unused qmi_elem_info arrays

From: Krzysztof Kozlowski

Date: Fri Oct 30 2026 - 02:44:33 EST


On 29/10/2026 20:54, Jeff Johnson wrote:
> On 10/29/2026 4:11 AM, Krzysztof Kozlowski wrote:
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>
>> 'wlfw_pin_connect_result_ind_msg_v01_ei' and
>> 'wlfw_initiate_cal_download_ind_msg_v01_ei' are not used anywhere.
>> Dropping them allows to remove bunch of other code referenced purely by
>> these ararys.
>
> s/ararys/arrays/
>
> this removes a lot of stuff, by review agent says there is more that can be
> removed...
>
> qmi_wlfw_v01.c
> - static const … wlfw_mem_seg_s_v01_ei[] — line 188
> - static const … wlfw_mem_seg_resp_s_v01_ei[] — line 229
>
> qmi_wlfw_v01.h (removable once the two .c arrays above are gone)
> - struct wlfw_mem_seg_s_v01 — line 161
> - struct wlfw_mem_seg_resp_s_v01 — line 168

I got LKP reports for these too.

>
> qmi_wlfw_v01.h — now-orphaned size constants (0 refs)
> - #define QMI_WLFW_MAX_NUM_MEM_SEG_V01 — line 64
> - #define QMI_WLFW_FUNCTION_NAME_LEN_V01 — line 67
> - #define QMI_WLFW_MAX_ATHDIAG_DATA_SIZE_V01 — line 70
> - #define QMI_WLFW_MAC_ADDR_SIZE_V01 — line 76


Ack

Best regards,
Krzysztof