Re: [PATCH net] netdevsim: delete ports added after a failed reload

[Mina Almasry]

On Wed, Oct 28, 2026 at 8:02 PM Joas Antonio dos Santos
<joasantonio108@xxxxxxxxx> wrote:
>
> diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
> index feb88cc..a871790 100644
> --- a/drivers/net/netdevsim/dev.c
> +++ b/drivers/net/netdevsim/dev.c
> @@ -1697,8 +1697,13 @@ static void nsim_dev_reload_destroy(struct nsim_dev *nsim_dev)
>  {
>         struct devlink *devlink = priv_to_devlink(nsim_dev);
>
> -       if (devlink_is_reload_failed(devlink))
> +       if (devlink_is_reload_failed(devlink)) {
> +               /* The failed reload already tore everything down, but ports
> +                * can still be added through new_port after that.
> +                */
> +               nsim_dev_port_del_all(nsim_dev);
>                 return;
> +       }

I prefer Ömer's version for the reasons mentioned here:
https://lore.kernel.org/netdev/20261030064245.4118081-1-almasrymina@xxxxxxxxxx/

Either way, since this is a non-critical fix in netdevsim, it should
target net-next once it reopens after the merge window:
https://netdev.bots.linux.dev/net-next.html

-- 
Thanks,
Mina