Re: [PATCH net-next v3] net: phy: aquantia: Add support for 5GbaseR

[Hongmei Xu]

On Thu, Oct 29, 2026 at 9:28 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > @@ -786,7 +790,8 @@ static int aqr_gen1_config_init(struct phy_device *phydev)
> >           phydev->interface != PHY_INTERFACE_MODE_10GKR &&
> >           phydev->interface != PHY_INTERFACE_MODE_10GBASER &&
> >           phydev->interface != PHY_INTERFACE_MODE_XAUI &&
> > -         phydev->interface != PHY_INTERFACE_MODE_RXAUI)
> > +         phydev->interface != PHY_INTERFACE_MODE_RXAUI &&
> > +         phydev->interface != PHY_INTERFACE_MODE_5GBASER)
>
> This is sorted based on speed. So 5GBASER goes earlier in the list.
Will fix in v4 — kept the interface modes sorted by speed.
>
> >  {
> >       if (iface == PHY_INTERFACE_MODE_10GBASER ||
> > -         iface == PHY_INTERFACE_MODE_2500BASEX)
> > +         iface == PHY_INTERFACE_MODE_2500BASEX ||
> > +         iface == PHY_INTERFACE_MODE_5GBASER)
> >               return RATE_MATCH_PAUSE;
>
> Please keep this in order, 10, 5, 2.5.
>
>     Andrew
>
> ---
> pw-bot: cr
Will fix in v4 — kept the rate matching conditions sorted by speed.

Regards,
Hongmei Xu