Re: [PATCH] mmc: omap_hsmmc: Do not log error on probe defer

[Ulf Hansson]

On Wed, Oct 14, 2026 at 7:44 PM Ettore Chimenti
<ettore.chimenti@xxxxxxxxxx> wrote:
>
> From: Andrew Goodbody <andrew.goodbody@xxxxxxxxxx>
>
> Do not print an error message to the log if the return code is
> EPROBE_DEFER by using dev_err_probe instead of dev_err.
>
> Signed-off-by: Andrew Goodbody <andrew.goodbody@xxxxxxxxxx>
> Signed-off-by: Ettore Chimenti <ettore.chimenti@xxxxxxxxxx>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/omap_hsmmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index de5a3b70107d..ed52adb38fd5 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -1892,15 +1892,15 @@ static int omap_hsmmc_probe(struct platform_device *pdev)
>
>         host->rx_chan = dma_request_chan(&pdev->dev, "rx");
>         if (IS_ERR(host->rx_chan)) {
> -               dev_err(mmc_dev(host->mmc), "RX DMA channel request failed\n");
>                 ret = PTR_ERR(host->rx_chan);
> +               dev_err_probe(mmc_dev(host->mmc), ret, "RX DMA channel request failed\n");
>                 goto err_irq;
>         }
>
>         host->tx_chan = dma_request_chan(&pdev->dev, "tx");
>         if (IS_ERR(host->tx_chan)) {
> -               dev_err(mmc_dev(host->mmc), "TX DMA channel request failed\n");
>                 ret = PTR_ERR(host->tx_chan);
> +               dev_err_probe(mmc_dev(host->mmc), ret, "TX DMA channel request failed\n");
>                 goto err_irq;
>         }
>
>
> ---
> base-commit: 0fcb05b72344f40806cbe810de8872f1698bf053
> change-id: 20261014-patch-ektor5-dm8168-mmc-138c9ab3f014
>
> Best regards,
> --
> Ettore Chimenti <ettore.chimenti@xxxxxxxxxx>
>