Re: [PATCH 2/3] thermal/drivers/amlogic: add S4 support

[Krzysztof Kozlowski]

On Sun, Oct 25, 2026 at 08:22:43PM +0100, christian.koever-draxl@xxxxxxxxxxxxxxxxxx wrote:
> From: Christian Stefan Kövér-Draxl <ckoever@xxxxxxxxxx>
> 
> The S4 CPU sensor reads its calibration through the secure monitor and
> otherwise matches the T7 setup, so reuse the T7 data for it.

So is it or is it not compatible with T7?
> 
> Without the calibration the driver reported about -144 degrees Celsius
> on an S905W2 board; with it the readings are plausible and CPU
> throttling engages.
> 
> Signed-off-by: Christian Stefan Kövér-Draxl <ckoever@xxxxxxxxxx>
> ---
>  drivers/thermal/amlogic_thermal.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
> index 60728de6968a..c58bac633bed 100644
> --- a/drivers/thermal/amlogic_thermal.c
> +++ b/drivers/thermal/amlogic_thermal.c
> @@ -292,6 +292,10 @@ static const struct of_device_id of_amlogic_thermal_match[] = {
>  		.compatible = "amlogic,a1-cpu-thermal",
>  		.data = &amlogic_thermal_a1_cpu_param,
>  	},
> +	{
> +		.compatible = "amlogic,s4-cpu-thermal",
> +		.data = &amlogic_thermal_t7_param,
> +	},
>  	{

This clearly suggests they are compatible.

Best regards,
Krzysztof