Re: [PATCH 1/4] dt-bindings: clock: Add Ingenic X1600 CGU bindings

[Krzysztof Kozlowski]

On Sun, Oct 25, 2026 at 08:18:24PM +0100, H. Nikolaus Schaller wrote:
> Add the device tree bindings and the clock ID definitions for the
> Clock Generation Unit (CGU) of the Ingenic X1600 SoC.
> 
> The clock layout features specific I2S handling. To properly support
> the I2S controllers on the X1600 without relying on complex compound
> dividers that are not yet natively supported by the drivers, split
> the structures to explicitly describe the additional I2S divider
> fields. This design accounts for the current driver limitations
> regarding division encoding while matching the hardware's internal
> gating architecture.
> 
> Furthermore, introduce dedicated I2S0 RX and TX clock definitions to
> allow independent and precise routing for I2S stream usage.
> 
> Co-developed-by: Paul Boddie <paul@xxxxxxxxxxxxx>
> Signed-off-by: Paul Boddie <paul@xxxxxxxxxxxxx>
> Co-developed-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
> ---

One more nit:

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23

Best regards,
Krzysztof