Re: [PATCH 1/2] dt-bindings: display: solomon,ssd132x: Add col-offset and dclk properties for the SSD1322

[Krzysztof Kozlowski]

On Thu, Oct 29, 2026 at 04:57:50PM -0400, Fabio Piparo wrote:
> Add solomon,col-offset, solomon,dclk-div and solomon,dclk-frq for the
> SSD1322, to set where the panel sits in the controller's columns and
> the panel's refresh rate. On the SSD1322 the clock divisor is a power
> of two, from 1 to 1024.
> 
> Assisted-by: LLM
> Signed-off-by: Fabio Piparo <holofermes@xxxxxxxxx>
> ---
>  .../bindings/display/solomon,ssd132x.yaml     | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/solomon,ssd132x.yaml b/Documentation/devicetree/bindings/display/solomon,ssd132x.yaml
> index dd7939989cf..6c7830af0e5 100644
> --- a/Documentation/devicetree/bindings/display/solomon,ssd132x.yaml
> +++ b/Documentation/devicetree/bindings/display/solomon,ssd132x.yaml
> @@ -16,6 +16,29 @@ properties:
>        - solomon,ssd1325
>        - solomon,ssd1327
>  
> +  solomon,col-offset:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    maximum: 119
> +    default: 0
> +    description:
> +      Offset of columns that the screen is mapped to, in units of four
> +      pixels.
> +
> +  solomon,dclk-div:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [1, 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024]
> +    default: 2
> +    description:
> +      Clock divisor.

Why this cannot be deduced from clock frequency?

> +
> +  solomon,dclk-frq:
> +    $ref: /schemas/types.yaml#/definitions/uint32

Use either existing properties or - if there aren't such - existing unit
suffixes.
https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml

> +    minimum: 0
> +    maximum: 15
> +    default: 9
> +    description:
> +      Clock frequency, higher value means higher frequency.

Why would the frequency be fixed/static?

> +
>  required:
>    - compatible

Best regards,
Krzysztof