Re: [PATCH 1/2] mac80211: move static function from header to referenced file
From: Omer El Idrissi
Date: Fri Oct 30 2026 - 09:24:12 EST
Move static function from header file to only c file it's used in.why? all the drv_ inlines are in driver-ops.h
first rule of commit text is to describe the problem you are tying to solve.
don't add unnecessary churn to the wireless code.
i moved it because multiple files include the header and when those are compiled they don't see the tracepoint definition because the next patch ifdef guards it under the same config that enables the only file the static function that uses the tracepoint is called from.
this static function was only used in that file and i didn't see any obvious reason for it's existance in that header so i moved it to the file where it's used.
commit messages are kept in the git history. should i send a v2 with a better commit message? or is the patch series problematic otherwise?