Re: [PATCH rtw-next v2] wifi: rtw88: usb: don't report the aggregation buffer as a frame

[Luka Gejak]

Hi Jie Feng,

Thanks for the v2. The fix looks right to me, just one small comment
below.

October 30, 2026 at 4:46 AM, "Ho Jie Feng" <hjf3108@xxxxxxxxx> wrote:

> diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c
> index 715a2ce342d92..d6ad0770657d7 100644
> --- a/drivers/net/wireless/realtek/rtw88/usb.c
> +++ b/drivers/net/wireless/realtek/rtw88/usb.c
> @@ -342,6 +342,11 @@ static void rtw_usb_write_port_tx_complete(struct urb *urb)
>
>               skb_pull(skb, rtwdev->chip->tx_pkt_desc_sz);
>
> +             if (tx_data->drv_frame) {
> +                     dev_kfree_skb_any(skb);
> +                     continue;
> +             }
> +

As far as I can see this is the normal TX completion of the aggregate
buffer, so I think dev_consume_skb_any() fits better here.
dev_kfree_skb_any() frees it with SKB_DROP_REASON_NOT_SPECIFIED, so each
aggregated transfer would now show up as a drop in the skb:kfree_skb
tracepoint and in drop monitor.

Before this patch the buffer went through mac80211, which in the usual
case freed it with dev_kfree_skb(), and that is consume_skb().

Best regards,
Luka Gejak