Re: [PATCH v2] soc: qcom: pd-mapper: Add support for the Qualcomm Shikra SoC

[Abel Vesa]

On 26-10-30 18:03:56, Anurag Pateriya wrote:
> Add support for the Qualcomm Shikra SoC to the protection domain mapper.
> 
> All Shikra SoC variants (CQM, CQS, IQS) share the same protection
> domain requirements: cdsp_root_pd, mpss_root_pd, mpss_wlan_pd.
> 
> Signed-off-by: Anurag Pateriya <anurag.pateriya@xxxxxxxxxxxxxxxx>
> ---
> Add support for the Qualcomm Shikra SoC to the protection domain mapper.
> 
> All Shikra SoC variants (CQM, CQS, IQS) share the same protection
> domain requirements: cdsp_root_pd, mpss_root_pd, mpss_wlan_pd.
> 
> Signed-off-by: Anurag Pateriya <anurag.pateriya@xxxxxxxxxxxxxxxx>
> 
> Changes in v2:
> - Adding mpss_root_pd and cdsp_root_pd for all shikra domains. (Konrad)
> - Updated cover letter and commit body for all three protection domains.
> ---
>  drivers/soc/qcom/qcom_pd_mapper.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/soc/qcom/qcom_pd_mapper.c b/drivers/soc/qcom/qcom_pd_mapper.c
> index 64ca99d7fad9..9e456ead9eb3 100644
> --- a/drivers/soc/qcom/qcom_pd_mapper.c
> +++ b/drivers/soc/qcom/qcom_pd_mapper.c
> @@ -498,6 +498,13 @@ static const struct qcom_pdm_domain_data *sc8280xp_domains[] = {
>  	NULL,
>  };
>  
> +static const struct qcom_pdm_domain_data *shikra_domains[] = {
> +	&cdsp_root_pd,
> +	&mpss_root_pd,
> +	&mpss_wlan_pd,
> +	NULL,
> +};
> +
>  /* Unlike SDM660, SDM630/636 lack CDSP */
>  static const struct qcom_pdm_domain_data *sdm630_domains[] = {
>  	&adsp_audio_pd,
> @@ -644,6 +651,7 @@ static const struct of_device_id qcom_pdm_domains[] __maybe_unused = {
>  	{ .compatible = "qcom,sc7280", .data = sc7280_domains, },
>  	{ .compatible = "qcom,sc8180x", .data = sc8180x_domains, },
>  	{ .compatible = "qcom,sc8280xp", .data = sc8280xp_domains, },
> +	{ .compatible = "qcom,shikra", .data = shikra_domains, },

Shouldn't this be alphabetically sorted?

>  	{ .compatible = "qcom,sdm630", .data = sdm630_domains, },
>  	{ .compatible = "qcom,sdm636", .data = sdm630_domains, },
>  	{ .compatible = "qcom,sda660", .data = sdm660_domains, },
> 
> ---
> base-commit: a39c950806213f6861d00f90729acaaa21f2d95a
> change-id: 20261028-shikra_pd-568b9b35056e
> 
> Best regards,
> -- 
> Anurag Pateriya <anurag.pateriya@xxxxxxxxxxxxxxxx>
> 

Looks good to me otherwise, so:

Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>