[PATCH 3/3] media: ivtv: Fix potential double free on ALSA initialization failure
From: Guangshuo Li
Date: Fri Oct 30 2026 - 12:55:35 EST
After snd_ivtv_card_create() succeeds, the card's private_free callback
owns itvsc. snd_card_free() already invokes that callback on subsequent
initialization failures, so the explicit kfree() frees itvsc twice.
Remove the redundant free.
This issue was found by our static analysis tool under development.
Fixes: 269c11fbac4f ("[media] ivtv, ivtv-alsa: Add initial ivtv-alsa interface driver for ivtv")
Cc: stable@xxxxxxxxxxxxxxx
Assisted-by: OpenAI:gpt-6-astra
Signed-off-by: Guangshuo Li <liguangshuo@xxxxxxxxxxxxxxx>
---
Build-tested the changed object with x86_64 allmodconfig.
No runtime or fault-injection testing was performed.
drivers/media/pci/ivtv/ivtv-alsa-main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/pci/ivtv/ivtv-alsa-main.c b/drivers/media/pci/ivtv/ivtv-alsa-main.c
index 59573debd19e..e06f194c0765 100644
--- a/drivers/media/pci/ivtv/ivtv-alsa-main.c
+++ b/drivers/media/pci/ivtv/ivtv-alsa-main.c
@@ -173,7 +173,6 @@ static int snd_ivtv_init(struct v4l2_device *v4l2_dev)
err_exit_free:
if (sc != NULL)
snd_card_free(sc);
- kfree(itvsc);
err_exit:
return ret;
}