Re: [PATCH v2 4/9] ARM: dts: omap: dm816x: refactor and align MMC node

[Ettore Chimenti]

Hi Andreas,

On Fri Oct 30, 2026 at 11:30 AM CET, Andreas Kemnade wrote:
> On Wed, 28 Oct 2026 17:06:05 +0100
> Ettore Chimenti <ettore.chimenti@xxxxxxxxxx> wrote:
>
>> From: Andrew Goodbody <andrew.goodbody@xxxxxxxxxx>
>> 
>> Update the MMC node in the TI Sitara DM816x device tree to align with
>> the structure used in other similar SoCs. The changes include
>> refactoring the node to better describe the target module and its
>> sub-nodes.
>> 
>> Signed-off-by: Andrew Goodbody <andrew.goodbody@xxxxxxxxxx>
>> Signed-off-by: Ettore Chimenti <ettore.chimenti@xxxxxxxxxx>
>> ---
>>  arch/arm/boot/dts/ti/omap/dm816x.dtsi | 33 +++++++++++++++++++++++++++------
>>  1 file changed, 27 insertions(+), 6 deletions(-)
>> 
>> diff --git a/arch/arm/boot/dts/ti/omap/dm816x.dtsi b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
>> index fc124f9ecfa1..e3d49651b44e 100644
>> --- a/arch/arm/boot/dts/ti/omap/dm816x.dtsi
>> +++ b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
>> @@ -423,13 +423,34 @@ &edma 20 0 &edma 21 0
>>  				    "tx2", "rx2", "tx3", "rx3";
>>  		};
>>  
>> -		mmc1: mmc@48060000 {
>> -			compatible = "ti,omap4-hsmmc";
>> -			reg = <0x48060000 0x11000>;
>> +		mmc1_target: target-module@48060000 {
>> +			compatible = "ti,sysc-omap2", "ti,sysc";
>>  			ti,hwmods = "mmc1";
>
> do we still need this?

No, we don't. I'll remove that in v3. 

As per the comment for patch 7 (USB node update), I'll send two separate
patches, one for DTS and one for the hwmod removal, making sure the
hwmod removal is applied last.

Thanks for your review,
Ettore