Re: [PATCH v6 07/18] nvme: Introduce FENCING and FENCED controller states

From: Mohamed Khalfella

Date: Fri Oct 30 2026 - 15:19:14 EST


On Fri 2026-10-30 11:32:52 +0100, Daniel Wagner wrote:
> On Wed, Oct 21, 2026 at 11:33:57AM -0700, Mohamed Khalfella wrote:
> > Is Documentation/ABI/stable/sysfs-nvme a living history of sysfs-nvme
> > documentation or a documentation for the specific kernel release?
>
> I understand it documents the sysfs API. sysfs is supposed to be stable,
> so adding a new state is factually a breaking change. The document
> should document the current API the kernel provides.

Looks like changing the "Date" or "KernelVersion" will make it like
"state" attribute has been added new newer kernel. That leaves one place
to mention "fencing" and "fenced" are added in newer kernel.

--- a/Documentation/ABI/stable/sysfs-nvme
+++ b/Documentation/ABI/stable/sysfs-nvme
@@ -145,8 +145,9 @@ KernelVersion: 4.11
Contact: Sagi Grimberg <sagi@xxxxxxxxxxx>
Description:
Shows the current state of the controller. Possible values:
- "new", "live", "resetting", "connecting", "deleting",
- "deleting (no IO)", "dead".
+ "new", "live", "fencing", "fenced", "resetting", "connecting",
+ "deleting", "deleting (no IO)", "dead". "fencing" and "fenced"
+ were added in 7.5.

What: /sys/class/nvme/nvmeX/numa_node
Date: November 2018


I added this diff to this patch. Let me know if you want me to change
it.