Re: [PATCH v2] regulator: dt-bindings: willsemi,wl2868c: add the WL2868C camera PMIC

[Qianhui Xu]

Hi Krzysztof,

one thing about the earlier replies before the technical part.  I am the
author of this series, but I work on this board alone and my English is
not good enough to write upstream mail unaided, so I draft with an AI
assistant and edit it myself; the content, measurements and decisions are
mine.  You were right that the earlier replies read like generated text.

1) "Looks like broken patch. Please use git or b4 to generate patches."
   The fault was in the commit message, not the diff: I had typed a
   diffstat into the body, so the mail carried two.  Since v2 the patches
   are real commits on pristine v7.3-rc7, exported with git format-patch.

2) "where is any user of this? Why do we want this binding?"
   The users are in patch 3/3, the board DTS for the Lenovo Legion Tab
   (TB322FC, SM8750): eight "*-supply = <&camera_ldoN>" references, rear
   s5kjns dvdd/dovdd/avdd = ldo1/ldo7/ldo4, front gc08a8 = ldo2/ldo7/ldo3,
   rear gt9764 VCM vdd/vddio = ldo5/ldo7.  LDO7 feeds three, LDO5 one,
   LDO1 to LDO4 one each; LDO6 is not wired out.  These are the camera
   subsystem's own rails, without them the sensors cannot be described, and
   they match the vendor DTS.  You saw no users because I sent the binding
   alone; v3 sends the three together.

3) "That's LLM output. Why do you paste it?", and your longer comment that
   the reply was generated text.
   Those points are fixed in v3: MAINTAINERS reads "WILLSEMI WL2868C CAMERA
   PMIC" (no driver claim), sorted between WIIMOTE and WILOCITY, and
   linux-media is dropped from its list.

4) "Please respond to comments from previous version."  Done here and in
   the v3 cover letter, together with Mark's v1 comments.

5) "I still see no users of this binding."  See 2).  If you would rather
   review the users first, say so and I will reorder the series.

Measured on v7.3-rc7, rebuilt from the patch files alone: checkpatch
--strict 0 errors in all three (3/3 has 5 warnings: the three sensor/lens
compatibles below, one MAINTAINERS false positive, one "DT binding docs
should be a separate patch" for a qcom.yaml line); dt-doc-validate and
dt-check-style rc=0; the board DTB builds rc=0 with no DTC errors (v2 died
with 15 phandle errors from the missing clocks), the only remaining dtc
warnings being pre-existing in sm8750.dtsi; dt-validate on it rc=0, 7 lines
left, all missing s5kjns / gc08a8 / gt9764 bindings; driver W=1 clean.

Gaps I know of: vin12/vin34/vin5..7-supply are not wired in the board DTS
yet, so the driver falls back to dummy supplies; enable_time and
max_register come from the vendor driver only; nothing is measured on
hardware beyond boot.

Thanks for reading.
Qianhui Xu