Re: [PATCH v2 2/2] clk: qcom: Add SM7250 graphics clock controller driver

[Ishu Brar]

On Tue, 27 Oct 2026 13:32:54 +0200, Abel Vesa wrote:
>> +static struct clk_branch gpu_cc_hlos1_vote_gpu_smmu_clk = {
>> +	.halt_reg = 0x5000,
>> +	.halt_check = BRANCH_HALT_VOTED,
>
> sm8250 uses BRANCH_VOTED here.

Yes, that is on purpose. BRANCH_VOTED skips the status poll on enable,
while BRANCH_HALT_VOTED still checks that the voted clock came up. The
newer GPU clock controller drivers (SM8350, SM8450, SM8550, SM8650,
SM8750, X1E80100) use BRANCH_HALT_VOTED for this clock. I tested it on
the Nord with the GPU SMMU as a consumer: the clock enables and there
are no "stuck at off" warnings.

Should i match SM8250 or keep BRANCH_HALT_VOTED iin v3?

Ishu Brar