Re: [PATCH] media: atomisp: Remove redundant return statements
From: Andy Shevchenko
Date: Sat Oct 31 2026 - 04:41:09 EST
On Fri, Oct 30, 2026 at 07:33:04PM +0000, Avishek Chaulagain wrote:
> A return statement at the end of a void function is redundant; control
> returns to the caller once the closing brace is reached. Remove the two
> such 'return;' statements in hmm_bo_release() and hmm_bo_vunmap(), as
> reported by checkpatch.pl.
Usually we expect deeper cleanups for this driver, see [1] for the best
(so far) example how somebody can help with it without having deep knowledge
on the particular hardware.
This type of change has been appeared many times in the mailing list, you
can study the case why it's still not in the upstream.
[1]: https://lore.kernel.org/linux-media/20261027230807.2407261-1-vladurares@xxxxxxxxx/
--
With Best Regards,
Andy Shevchenko