[PATCH 2/2] Input: cs40l50 - fix work item leak in stop worker
From: Ismail Tarim
Date: Sat Oct 31 2026 - 05:55:19 EST
cs40l50_playback() allocates a work item for every playback request,
and the start and stop workers are responsible for freeing it.
cs40l50_stop_worker() returns early when pm_runtime_resume_and_get()
fails and never frees the item.
Free it on that path too, as cs40l50_start_worker() already does.
Fixes: c38fe1bb5d21 ("Input: cs40l50 - Add support for the CS40L50 haptic driver")
Signed-off-by: Ismail Tarim <ismailtarim7@xxxxxxxxx>
---
Build-tested only (W=1, x86_64 defconfig with the CS40L50 drivers as
modules). I do not have CS40L50 hardware, so this was not runtime
tested.
drivers/input/misc/cs40l50-vibra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/misc/cs40l50-vibra.c b/drivers/input/misc/cs40l50-vibra.c
index 68f0c40ef..cbe69f6c7 100644
--- a/drivers/input/misc/cs40l50-vibra.c
+++ b/drivers/input/misc/cs40l50-vibra.c
@@ -384,12 +384,12 @@ static void cs40l50_stop_worker(struct work_struct *work)
struct cs40l50_vibra *vib = work_data->vib;
if (pm_runtime_resume_and_get(vib->dev) < 0)
- return;
+ goto err_free;
vib->dsp.write(vib->dev, vib->regmap, vib->dsp.stop_cmd);
pm_runtime_put_autosuspend(vib->dev);
-
+err_free:
kfree(work_data);
}
--
2.56.0