Re: [PATCH 01/23] net: hpe: ss1: add the Cassini headers

[Andrew Lunn]

On Fri, Oct 30, 2026 at 01:58:57PM -0700, Doug Ledford wrote:
> Start the Cassini core driver (cxi-ss1) with its headers: the register
> and counter definitions, error definitions, telemetry item tables, and
> the CXI interface (cxi.h, cxi_prov_hw.h, libcassini.h) through which
> client drivers use the NIC.
> 
> The cassini_* headers are generated from the hardware description and
> are not meant to be edited by hand, so they carry the generator's
> formatting.  cassini_user_defs.h is shared byte-for-byte with the user
> space libraries and is therefore under include/uapi/ethernet.

You want to keep the UAPI as small as possible, because once this is
merged, it can never change in ways that break backwards
compatibility. 

We also strongly discourage APIs that allow user space drivers, which,
at first glance, such definitions would allow. 


> It
> provides inline accessors that need errno.h, string.h and size_t,
> which a standalone UAPI header cannot assume, so this patch excludes
> it from the UAPI header self-test.

Does any other driver do this? If you are doing something which no
other driver does, it is probably broken.

> checkpatch --strict (100 columns) still reports the following in this
> patch.

netdev prefers 80.

> They need coordination with the internal repositories this code
> is maintained in and will be fixed in V2:

Your internal repos don't matter. Once this is merged it has a life of
its own.

	Andrew