Re: [PATCH v12 01/17] HID: asus: size feature reports from the HID report descriptor

[Rebecca Mara Müller]

Hi Denis,

as asked in the cover letter, I repeated the Zenbook Duo test on v12.
Everything that worked with v11 still works.

Setup as for v11: hid.git for-next (hid-asus.c f6aa1be09ad5), your
v12 01-12, then Paolo's v4 1-4 and 6-7, leaving out 5/7, which this
patch replaces. Your patches applied cleanly, and Paolo's went on top
of the reworked 01/17 without conflicts (4/7 with the same trivial
fixup as last time). Built out-of-tree with W=1 against a 7.2.6-based
distribution kernel, no warnings from hid-asus.c. UX8407AA, my
userspace workaround stopped.

- Docked (USB, 0b05:1cd7), captured with usbmon while reloading the
  module and pressing the backlight key: 5 SET and 2 GET, every one of
  them report 0x5a on interface 4 with wLength 16, all completed with
  status 0. It is the same sequence as with v11: the handshake and its
  read-back, the 0x05 function query and its GET, the initial
  brightness and two changes. The backlight key and Fn+F (platform
  profile) work.
- Bluetooth (0b05:1cd8): the backlight key and Fn+F work, no errors
  in the log.
- After docking again: the backlight key and Fn+F still work.

Tested-by: Rebecca Mara Müller <rebecca.mara@xxxxxxxxx> # UX8407AA

One small thing I noticed while applying: 06/17 adds 14 lines that
contain only a single space, and git am warns about trailing
whitespace. checkpatch will probably flag them too.

Thanks,
Rebecca