Re: [PATCH ath-next 3/3] wifi: ath11k: add a module parameter to select the hardware mode

[Julius Bairaktaris]

On 10/28/2026 12:03 PM, Jeff Johnson wrote:
> Is there a different way?
> Adding new module params is frowned upon.
> https://www.google.com/url?q=https://msgid.link/6d553cffcb0ae84e141006ae1430f6f37909ad2b.camel@xxxxxxxxxxxxxxxx&source=gmail&ust=1793562736182000&sa=E

Yes. Which mode the NBG7815 should run is a property of the board: Zyxel
specifies it with one 8x8 5 GHz radio and 160 MHz [1], and its board
data makes the firmware advertise DBS for that. ath11k can then pick the
mode from the machine compatible, the way
ath11k_core_usecase_firmware_table[] picks the firmware for WCN6855
boards since commit c386a2b10689 ("wifi: ath11k: add usecase firmware
handling based on device compatible").

For v2 I would replace 3/3 with a table of hw_rev, compatible and hw
mode, with one entry:

{ ATH11K_HW_IPQ8074, "zyxel,nbg7815", WMI_HOST_HW_MODE_DBS },

ath11k_wmi_tlv_hw_mode_caps() takes that mode if the firmware advertises
it and otherwise keeps today's choice. No parameter and no new binding.
1/3 and 2/3 stay as they are.

A property on the wifi node would describe configuration rather than
hardware, and the series above deprecated firmware-name in favour of
the table. A runtime switch does not fit either: the mode goes to the
firmware in WMI_INIT_CMDID and fixes the number of radios ath11k
registers, one ieee80211_hw each, so changing it means a firmware
restart and a new set of wiphys.

Does that work for you?

[1] https://download.zyxel.com/Armor_G5_(NBG7815)/datasheet/Armor%20G5%20(NBG7815)_4.pdf