Re: [PATCH 00/23] Subject: [PATCH net-next 00/23] net/hpe: add HPE Slingshot NIC drivers

From: Andrew Lunn

Date: Sat Oct 31 2026 - 16:18:22 EST


On Fri, Oct 30, 2026 at 03:11:21PM -0700, Jakub Kicinski wrote:
> On Fri, 30 Oct 2026 13:58:56 -0700 Doug Ledford wrote:
> > 416 files changed, 185137 insertions(+)
>
> 🤣️

Yes, this patchset is going nowhere.

Please throw out everything except the absolute bare minimum.
Ethtool, is not needed in the first patchset. All the UAPI stuff is
not needed. All the sysfs stuff is gone. One PF, no VF. All the custom
debug macros can go, etc.

If you manage to get that absolute minimum base driver merged, you can
then start adding patchsets to flesh out the driver. Eventually you
can get to the controversial stuff, like sysfs, uapi, etc, and you can
argue your case why your driver is special and needs this.

And as a bit of an aside, how much has an LLM been chewing on the code
and spitting out issues? The prompts used by netdev are available, you
can run it yourself. So you might want to address as many as you can
before posting code to the list. That will avoid you reaching v42 of
the absolute bare minimum patchset.

Andrew