Re: [PATCH] staging: octeon: remove unused cvmx_pko_get_base_queue_per_core() stub

[Vladu Rares]

On Sat, 31 Oct 2026 at 22:31, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Sat, Oct 31, 2026 at 04:09:02PM +0000, Rareș-Mihai Vladu wrote:
> > cvmx_pko_get_base_queue_per_core() is not used by the driver, so its
> > stub for COMPILE_TEST builds is never called. Remove it.
> >
> > Signed-off-by: Rareș-Mihai Vladu <vladurares@xxxxxxxxx>
>
> How was this found and tested?

I found it by checking every function and macro defined in
octeon-stubs.h against the rest of the driver with grep. This was the
only stub with no user. The real cvmx_pko_get_base_queue_per_core() in
arch/mips is still used there and is not touched.

octeon-stubs.h is only included from octeon-ethernet.h when
CONFIG_CAVIUM_OCTEON_SOC is not set, so the change only affects
COMPILE_TEST builds. I built the driver with COMPILE_TEST on x86_64
and it builds without warnings.

I can send a v2 with this in the changelog if you want.

Thanks,
Rareș