Re: [PATCH rtw-next v9 2/3] wifi: rtw88: support channel switch in AP mode

From: Mehmet Fide

Date: Sat Oct 31 2026 - 17:19:54 EST


Hi Luka,

Thanks for the review.

> Maybe clear csa_vif again at the end of rtw_core_stop(), once the mutex
> is taken back?

Yes. The USB chips never start the recovery, rtw_fw_c2h_cmd_isr() is
only called from pci.c, so I started it from a test hook on an
RTL8821CU, held rtw_core_stop() open for 3 s with the mutex dropped and
started a switch in that time:

- before the cancels: the countdown never finished and the next switch
was refused, 3 of 3 runs;
- after cancel_delayed_work_sync(): the work stayed queued with csa_vif
set, ran after the power off, and the restart then failed to download
the firmware, 3 of 3 runs.

With csa_vif cleared again after the mutex_lock(), the switch completed
in all 6 runs. v10 does that.

Mehmet