Re: [PATCH 4/4] rhashtable: fix vmalloc() deadlock in atomic rehash
From: Herbert Xu
Date: Sat Oct 31 2026 - 20:20:28 EST
On Fri, Oct 30, 2026 at 08:56:03PM -0400, Liam R. Howlett (Google) wrote:
>
> Hubert, I have another version of this patch set to send out, but this
> particular patch remains the same.
>
> Are you okay with keeping it the way it is for this release?
>
> I don't want to force your hand but I also don't want to keep a valid
> deadlock scenario in-tree.
Instead of your patch, please revert the original change that
added kvmalloc to rhashtable:
commit 93f976b5190df32793908d49165f78e67fcb66cf
Author: Davidlohr Bueso <dave@xxxxxxxxxxxx>
Date: Tue Aug 21 22:01:45 2018 -0700
lib/rhashtable: simplify bucket_table_alloc()
The newly added alloc_hooks_tag call should go after the if statement.
This patch should also be split out of your series and posted to
linux-crypto.
Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt