Re: [PATCH] iio: adc: qcom-spmi-adc5-gen3: Reuse IIO device ID for ADC_TM auxiliary device
From: Shawn Guo
Date: Sat Oct 31 2026 - 23:15:37 EST
On Sun, Nov 01, 2026 at 02:00:47AM +0000, Jonathan Cameron wrote:
> On Wed, 28 Oct 2026 15:09:47 +0100
> Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx> wrote:
>
> Hi Loic,
>
> > A recent fix in ADC5 Gen3 driver allocates a dedicated auxiliary-device
> > ID through an IDA to ensure that ADC_TM auxiliary devices receive unique
> > names on the auxiliary bus.
> When talking about another patch I'd refer to it by name and ideally
> also add a Link tag to the lore.kernel.org for it to the tags block.
> I think you mean:
>
> iio: adc: qcom-spmi-adc5-gen3: Allocate unique ADC_TM aux device IDs
> Link: https://lore.kernel.org/all/20261008031154.3440632-1-shengchao.guo@xxxxxxxxxxxxxxxx/
>
> >
> > However, each ADC instance is already assigned a unique IIO device ID.
> > Reuse that existing identifier when registering the ADC_TM auxiliary
> > device instead of maintaining a separate IDA solely for auxiliary device
> > naming.
> >
> > This removes the custom ID allocation and release handling while
> > preserving unique auxiliary device names across multiple ADC instances.
>
> >
> > Signed-off-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>
>
>
> The fix hasn't gone upstream yet (assuming it is the patch I think
> it is!). Would it be better to just squash this onto that patch
> and avoid having to care about a version of the intermediate code?
>
> +CC Shawn.
Thanks for looping me, Jonathan!
I agree with you on the squashing. I just sent you the squashed version
(with Loic being author) [1], so that you can just replace the one in
your queue.
Shawn
[1] https://lore.kernel.org/all/20261101030902.1387122-1-shengchao.guo@xxxxxxxxxxxxxxxx/