Re: [PATCH] tg3: make depend on ZONE_DMA

[Jason Xing]

On Sat, Oct 31, 2026 at 9:36 PM Rui Salvaterra <rsalvaterra@xxxxxxxxx> wrote:
>
> Since 614f4d166eee, on systems with ZONE_DMA unavailable, the Tigon3 driver
> fails to initialize, at least on systems with BCM57766 controllers. On a late
> 2012 Mac Mini:
>
> [    1.226623] tg3 0000:01:00.0: Unable to obtain 64 bit DMA for consistent allocations
> [    1.226718] tg3 0000:01:00.0: probe with driver tg3 failed with error -5
>
> Fixes: 614f4d166eee "tg3: Set coherent DMA mask bits to 31 for BCM57766 chipsets"

The format is not right. And please target net branch if it's a fix by
changing your title to ']PATCH net]'.

>
> Cc: stable@xxxxxxxxxxxxxxx
>
> Signed-off-by: Rui Salvaterra <rsalvaterra@xxxxxxxxx>
> ---
>  drivers/net/ethernet/broadcom/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
> index f0bac0dd1439..c9875daa043b 100644
> --- a/drivers/net/ethernet/broadcom/Kconfig
> +++ b/drivers/net/ethernet/broadcom/Kconfig
> @@ -124,6 +124,7 @@ config TIGON3
>         tristate "Broadcom Tigon3 support"
>         depends on PCI
>         depends on PTP_1588_CLOCK_OPTIONAL
> +       depends on ZONE_DMA

Did you verify it possibly affects those kernels without DMA config?

The blamed patch seems correct, so I think you need to root cause it
instead of adding a global dependency here.

Thanks,
Jason

>         select CRC32
>         select PHYLIB
>         help
> --
> 2.55.0
>
>