Re: [PATCH] iio: gyro: mpu3050: Fix runtime PM refcount leak in trigger enable path

From: laixiangwu

Date: Sun Nov 01 2026 - 04:25:50 EST


Hi Jonathan,

Thank you for the review!

Both suggestions are addressed in v2, which I just sent:

- The enable and disable paths are now split out of
mpu3050_drdy_trigger_set_state() into a pair of separate helpers
in a precursor patch (1/2), so the error label only lives inside
mpu3050_drdy_trigger_enable().
- The fix (2/2) now uses pm_runtime_resume_and_get() instead of
pm_runtime_get_sync(), which also keeps the usage counter balanced
when the resume fails, so the manual pm_runtime_put_noidle() from
v1 is no longer needed.

Best regards,
laixiangwu