Re: [PATCH 1/2] dt-bindings: iio: light: Add Capella CM3217

From: Jonathan Cameron

Date: Sun Nov 01 2026 - 12:48:44 EST


On Sun, 01 Nov 2026 15:46:06 +0100
Patrick Fischer via B4 Relay <devnull+admin.tsv-stahl-riesa.de@xxxxxxxxxx> wrote:

> From: Patrick Fischer <admin@xxxxxxxxxxxxxxxxxx>
>
> The Capella CM3217 is an ambient light sensor with an I2C interface but
> without registers and without an interrupt line. It always answers on
> the two addresses 0x10 and 0x11. The node describes the first address;
> the second one is fixed and claimed by the driver.
>
> The sensor is used in the NVIDIA Tegra Note 7 and the NVIDIA Shield
> Tablet.
>
> Signed-off-by: Patrick Fischer <admin@xxxxxxxxxxxxxxxxxx>

Hi Patrick

One small thing inline.

> ---
> .../bindings/iio/light/capella,cm3217.yaml | 45 ++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/capella,cm3217.yaml b/Documentation/devicetree/bindings/iio/light/capella,cm3217.yaml
> new file mode 100644
> index 000000000000..b2ddb14d657b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/capella,cm3217.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/capella,cm3217.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Capella CM3217 ambient light sensor
> +
> +maintainers:
> + - Patrick Fischer <admin@xxxxxxxxxxxxxxxxxx>
> +
> +description:
> + The CM3217 is an I2C ambient light sensor without registers or interrupt
> + line. It always occupies the two I2C addresses 0x10 and 0x11; the node
> + describes the first one.
> +
> +properties:
> + compatible:
> + const: capella,cm3217
> +
> + reg:
> + const: 0x10

Put the documentation about using who I2C bus addresses here rather than
in the introduction. This is where anyone wondering about allowed reg for
a device that sits on two addresses would look. Maybe add a little
on what goes to each address.

> +
> + vdd-supply: true
> +
> +required:
> + - compatible
> + - reg
> + - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + light-sensor@10 {
> + compatible = "capella,cm3217";
> + reg = <0x10>;
> + vdd-supply = <&vdd_2v85_sen>;
> + };
> + };
> +...
>