Re: [PATCH 2/5] mm/vmscan: move code to lru_gen_{add,del}_memcg()

From: Barry Song

Date: Sun Nov 01 2026 - 16:03:57 EST


On Tue, Oct 13, 2026 at 4:55 AM Max Kellermann <max.kellermann@xxxxxxxxx> wrote:
>
> Preparation for the following patch that adds tail caching.
>
> For simplicity, hlist_nulls_del_init_rcu() is now always used, which
> is also valid during rotation, because the entry is immediately
> reinserted under `memcg_lru.lock`.
>
> Signed-off-by: Max Kellermann <max.kellermann@xxxxxxxxx>
> ---
> mm/vmscan.c | 36 ++++++++++++++++++++++++++++--------
> 1 file changed, 28 insertions(+), 8 deletions(-)

[...]
> + lru_gen_del_memcg(&pgdat->memcg_lru, &lruvec->lrugen, old);
> + lru_gen_add_memcg(&pgdat->memcg_lru, &lruvec->lrugen, new, bin,
> + op == MEMCG_LRU_HEAD || op == MEMCG_LRU_OLD);

T.J. series[1] removed MEMCG_LRU_OLD, i guess you will need some rebase.

[1] https://lore.kernel.org/linux-mm/20261028010611.3929937-1-tjmercier@xxxxxxxxxx/

Best,
Barry