Re: [PATCH v2 9/9] ARM: dts: omap: dm8168-evm: enable MUSB multipoint support

[Andreas Kemnade]

On Wed, 28 Oct 2026 17:06:10 +0100
Ettore Chimenti <ettore.chimenti@xxxxxxxxxx> wrote:

> From: Christopher Obbard <christopher.obbard@xxxxxxxxxx>
> 
> The DM8168 USB controllers are used in host mode and must advertise
> multipoint support to the MUSB core. Without this the kernel disables
> external hub support and warns:
> 
>     musb-hdrc: kernel must disable external hubs, please fix the
> 	configuration
> 
> On the affected board this also prevents devices from enumerating
> reliably, with descriptor reads failing with -EPROTO:
> 
>     usb 1-1: device descriptor read/all, error -71
> 
> Set mentor,multipoint to the default value of 1 for both MUSB instances.
> With this enabled, USB devices enumerate successfully on the host ports.
> 
> Signed-off-by: Christopher Obbard <christopher.obbard@xxxxxxxxxx>
> Signed-off-by: Ettore Chimenti <ettore.chimenti@xxxxxxxxxx>

Reviewed-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/ti/omap/dm8168-evm.dts | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/dm8168-evm.dts b/arch/arm/boot/dts/ti/omap/dm8168-evm.dts
> index a6d42766a496..4b4e4d850231 100644
> --- a/arch/arm/boot/dts/ti/omap/dm8168-evm.dts
> +++ b/arch/arm/boot/dts/ti/omap/dm8168-evm.dts
> @@ -198,17 +198,14 @@ &mmc1 {
>  	wp-gpios = <&gpio2 8 GPIO_ACTIVE_HIGH>;
>  };
>  
> -/* At least dm8168-evm rev c won't support multipoint, later may */
>  &usb0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&usb0_pins>;
> -	mentor,multipoint = <0>;
>  };
>  
>  &usb1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&usb1_pins>;
> -	mentor,multipoint = <0>;
>  };
>  
>  &sata {
>