Re: [PATCH v2 10/10] fdtfactor: Add compiled FIT image factoring support

[Doug Anderson]

Hi Simon,

On Fri, Oct 30, 2026 at 5:23 AM Simon Glass <sjg@xxxxxxxxxxxx> wrote:
>
> On Wed, 28 Oct 2026 at 15:56, Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
> >
> > Add `-F`/`--fit`, `--outfile`, and `--single-base-dtb` to `fdtfactor` so
> > it can directly factor `/images/fdt-*` blobs inside a compiled U-Boot /
> > ChromeOS Flattened Image Tree (FIT) image.
> ...
> > Assisted-by: Gemini:gemini-3-pro [edid_decode] [gerrit_and_build_artifacts] [gsheets_gdocs_cli]
> > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> > ---
> >
> > Changes in v2:
> > - Moved FIT image factoring into its own patch.
> > - Replaced external `fdtget`/`fdtput` subprocess calls with `NodeTree`.
> > - Added FIT `hash*` recalculation (`crc32`, `sha1`, `sha256`, etc.) and
> >   rejected signed FIT images (`signature*` subnodes) and external-data
> >   FIT images (`data-offset` / `data-position`).
> > - Preserved per-group compression (`lz4`, `lzma`, `xz`, `gzip`) on
> >   factored FIT `fdt-base-*` and `fdt-*` nodes.
> >
> >  README.md                 |  19 +++
> >  fdtfactor                 | 408 +++++++++++++++++++++++++++++++++++++-
> >  tests/fdtfactor_lz4.its   |  83 ++++++++
> >  tests/fdtfactor_other1.dts|  21 ++
> >  tests/fdtfactor_other2.dts|  21 ++
> >  tests/fdtfactor_test.its  |  83 ++++++++
> >  tests/run_tests.sh        | 156 +++++++++++++++
> >  7 files changed, 789 insertions(+), 2 deletions(-)
> >  create mode 100644 tests/fdtfactor_lz4.its
> >  create mode 100644 tests/fdtfactor_other1.dts
> >  create mode 100644 tests/fdtfactor_other2.dts
> >  create mode 100644 tests/fdtfactor_test.its
>
> Reviewed-by: Simon Glass <sjg@xxxxxxxxxxxx>
>
> BTW, 'FIT image' actually means an image in a FIT, so I think you
> should try to call the whole thing a 'FIT' instead.

Done. Updated the commit message, `README.md`, `fdtfactor`, and tests to
refer to the container as a "FIT" rather than a "FIT image".


-Doug