[RFC V2 PATCH 00/11] Re: ALSA: usb-audio: Audient iD14 MkI vendor

[Christian Ruppert]

Hi Will,

On Sun, Nov 01, 2026 at 11:35:57AM -0600, Will Porter wrote:
> [...]
> 
> 1. Patch 10, cache index
> 
> The cache has hwchannels entries, and the probe fills it by element
> index (cache[i]). But get, put and the INIT_HW write index it by device
> channel:
> [...]

Good catch and thanks for the fix, applied in RFC V2.

> 2. Probe-time USB errors now fail the whole card
> [...]
> Could we keep the card registering after a failed probe transfer, while
> keeping the cache entry invalid until a transfer succeeds?
> 
> To save a round, I wrote it out; the diff is at the end of this mail, on
> top of your series. Please change or drop anything that doesn't fit your
> plans.
> [...]

Fine with me, I suppose the question if individual reads should be allowed
to fail during driver initialization is more philosophical in this case.
I don't see any harm. Patch applied in RFC V2

> 3. Smaller points
> 
> - Patch 05: would sign_extend32(buf, 8 * ctype->len - 1) work in
>   place of the shift pair?
> - Patch 05: the buffers mix u32/s32 with cpu_to_le32()/le32_to_cpu().
>   Would __le32 buffers keep sparse quiet?

OK, these make the code a bit cleaner, added to RFC V2.

> - Patch 05: the transfer buffer is 4 bytes on the stack, but nothing
>   checks the table's len. Could snd_audient_add_ctrl() return -EINVAL
>   unless 1 <= len <= 4?

I don't think this is necessary as it should be rather obvious to everyone
touching the driver that the u32 argument can't carry more than 4 bytes.
Added a comment to the parameter definition.

> - Patch 09: with FORCE_SET, a put of the cached value still writes
>   (good) but also reports a change, so each alsactl restore sends a
>   change event for every such control. Could it write but return 0
>   when the cache already holds the value?

Makes sense. Added to RFC V2 (in patch 10 where the cache is added). Please
double-check if the logic reflects what you had in mind.

> - Patch 11: a device with no matrix list would dereference NULL in the
>   loop. Would a check on info->matrix_names be worth adding?

Makes sense although this could also be held off until somebody actually
adds such a device. Added to RFC V2.

> - Patch 01: FYI, the file header still says "Audient EVO driver for
>   ALSA".

Fixed in RFC V2.

> 4. iD14 tables on top
> 
> I built the iD14 tables on your series, with the cache fix applied.
> On an iD14 MkI they passed control read and write checks, the range
> checks and a loopback test of the matrix crosspoints. The crosspoints
> also kept their values across a module reload and were read back into
> the cache.
> 
> On top of your patches I needed three generic additions:
> 
> - a step size for integer types (res): the iD14 level controls use
>   s16 in 1/256 dB; I expose them in whole-dB steps, matching the
>   volume knob. The control counts steps from min, as the generic USB
>   mixer does with the RANGE resolution;
> - an enumerated type with a value list, plus one extra last item that
>   a get shows for a device value outside the list;
> - a per-device create hook, for the FU 12 control that does not fit
>   the tables (in the same patch as that control).
> 
> The matrix uses your loop as it is: with 2 channels per element and the
> names in the order Mic 1 Main, Mic 1 Cue, Mic 2 Main, ..., element n
> starts at CN 2 * n, which is input * 4 + output on the iD14. Does that
> fit what you had in mind?

Yep, sounds good.

> 5. Next steps
> 
> Would you prefer to incorporate these changes in an RFC v2, or shall I
> fold them into the relevant patches when I carry your series, with
> notes in the commit messages?

I created RFC V2 with your patch and the fixes you suggested. This will
make things easier to review when we submit the everything, compared to
fixes on top of a long series of patches.

Based on the same commit as before and retested on 7.3.1.

  Christian

Christian Ruppert (11):
  ALSA: rename mixer_evo to mixer_audient
  ALSA: mixer_audient: explicitly define full control names
  ALSA: mixer_audient: clarify USB control message definition
  ALSA: mixer_audient: Add length check to USB transfer
  ALSA: mixer_audient: make USB control transfer size configurable
  ALSA: mixer_audient: Allow arbitrary boolean control values
  ALSA: mixer_audient: Add integer range checks
  ALSA: mixer_audient: Add control initialization at probe
  ALSA: mixer_audient: Add readback-free parameter set
  ALSA: mixer_audient: add control value caching
  ALSA: mixer_audient: Create matrix programmatically

 MAINTAINERS               |   7 +-
 sound/usb/Makefile        |   2 +-
 sound/usb/mixer_audient.c | 702 ++++++++++++++++++++++++++++++++++++++
 sound/usb/mixer_audient.h |  12 +
 sound/usb/mixer_evo.c     | 526 ----------------------------
 sound/usb/mixer_evo.h     |  12 -
 sound/usb/mixer_quirks.c  |   4 +-
 7 files changed, 721 insertions(+), 544 deletions(-)
 create mode 100644 sound/usb/mixer_audient.c
 create mode 100644 sound/usb/mixer_audient.h
 delete mode 100644 sound/usb/mixer_evo.c
 delete mode 100644 sound/usb/mixer_evo.h

-- 
2.56.0