Re: [PATCH] tg3: make depend on ZONE_DMA

From: Jason Xing

Date: Sun Nov 01 2026 - 21:26:19 EST


On Mon, Nov 2, 2026 at 3:41 AM Rui Salvaterra <rsalvaterra@xxxxxxxxx> wrote:
>
> Hi, Jason,
>
>
> On Sun, 1 Nov 2026 at 05:48, Jason Xing <kerneljasonxing@xxxxxxxxx> wrote:
> >
> [snipped]
> >
> > The blamed patch seems correct, so I think you need to root cause it
> > instead of adding a global dependency here.
>
> I'm sorry, perhaps I misunderstood, but *I* need to root cause it? I
> never claimed to fully understand the implications of the patch I

This is not how things are going here. As long as someone proposes a
patch, they should at least know what they are doing.

> sent, nor the intricacies of the tg3 driver. What I *do* understand is
> that a supposed "fix" from Broadcom has left the Ethernet controller
> on my late 2012 Mac Mini inoperable since the 24th November 2024, when
> absolutely nothing changed in my kconfig. That is, by definition, a
> regression. I'm entirely available for testing any patches people send
> my way, if whoever fully understands the driver and the hardware is
> unable to reproduce the issue. However, asking the user to fix a
> problem created by a patch from the hardware manufacturer is… an
> interesting approach, at best.

I see what you meant; I thought you were trying to make your first
contribution to the kernel :)

With that said, maintainers would pick up this and probably send a fix
with your credit (reported-by tag). Thanks for your report :)

Thanks,
Jason