Re: [PATCH v3] hugetlbfs: move hugetlbfs_free_inode tracepoint to ->destroy_inode()
From: Andrew Morton
Date: Sun Nov 01 2026 - 21:40:51 EST
On Mon, 2 Nov 2026 10:24:38 +0800 Muchun Song <muchun.song@xxxxxxxxx> wrote:
> > static void hugetlbfs_destroy_inode(struct inode *inode)
> > {
> > + /*
> > + * Not in ->free_inode(): that runs from an RCU callback, when the
> > + * superblock the event reads may already be freed.
> > + */
>
> Since the trace point name has already been changed, the comment here
> doesn't seem to serve much purpose anymore, as there isn't any ambiguity.
>
> With the comment removed:
>
> Reviewed-by: Muchun Song <muchun.song@xxxxxxxxx>
Thanks. I've added a note-to-self to track this, but I've left the
patch in-place as your observation doesn't invalidate ongoing testing.
I always do this! But this doesn't appear to to be widely known :(.
My fault, really.
My notes-to-self are mastered in
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/pc/devel-series,
so the overly-curious can always look up status in there.
If a patch has a note, I won't progress it until that note has been
cleared away. This often involves sending annoying private emails to
people, or fixing stuff myself.