Re: [PATCH v5] uniwill: Add support for MECHREVO WUJIE Series 15 X Pro

[Donjuanplatinum]

Armin Wolf <W_Armin@xxxxxx> writes:

> Am 11.10.26 um 10:14 schrieb Donjuanplatinum:
>


> Does the OEM control center for Windows support battery charging
> modes? If yes then you should also select
> UNIWILL_FEATURE_BATTERY_CHARGE_MODES.
>
> Other than that the patch looks fine to me, but i would be very happy
> if you could rebase it on the current for-next branch.
>
> Thanks, Armin Wolf

Hi Armin, I think some of my previous replies may have been missed. I
have added and tested the battery charging mode:

> > Can you check if UNIWILL_FEATURE_BATTERY_CHARGE_MODES also works on
> > your device?  Please note that the embedded controller will still
> > report to charge the battery to 100%, so this is not a reliable
> > indicator. Do you know if the Windows OEM app provides such a
> > setting on this device?
> >
> > Thanks, Armin Wolf
> >

> I also checked the battery charge modes in the Windows OEM
> application. The OEM application provides this setting.

> Additionally, I used the interfaces exposed by the OEM's
> ACPIDriverDll.dll to test the three charge modes and confirmed that
> their behavior matches the current implementation in the Uniwill
> driver.

This is the previous disscuss:
https://lore.kernel.org/platform-driver-x86/c8cb27ab-e5de-4a86-ad09-6610905e74b8@xxxxxx/T/#mf80e6c3fdad4eb3af835504c0e512df66c474c52



> Other than that the patch looks fine to me, but i would be very happy if you
> could rebase it on the current for-next branch.

I put the rebased patch here,it now base the for-next: