Re: [PATCH v3] arm64: dts: qcom: shikra-iqs: add M.2 Wi-Fi and Bluetooth overlay

[Linghui Wu]

Hi Rob,

Thank you, and sorry for not replying to the earlier Sashiko reports.

I have updated v4 to use the existing composite DTB build pattern:

shikra-iqs-evk-m2-wifi-bt-dtbs := \
        shikra-iqs-evk.dtb \
        shikra-iqs-evk-m2-wifi-bt.dtbo

dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-m2-wifi-bt.dtb
dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk-m2-wifi-bt.dtbo

The composite DTB target makes Kbuild apply the overlay to
shikra-iqs-evk.dtb and validates the symbols and fixups during the build.
The standalone DTBO is retained because the existing FIT flow loads the
base DTB and overlay separately.

I am rerunning the kernel build with this change before sending v4. I will
also reply to the individual Sashiko findings rather than leaving the
automated reports unanswered


On 10/22/2026 1:18 AM, Rob Herring wrote:
> On Mon, Oct 19, 2026 at 9:09 PM Linghui Wu <linghui.wu@xxxxxxxxxxxxxxxx> wrote:
> > Add an overlay for M.2 Key-E Wi-Fi and Bluetooth modules on the Qualcomm
> > Shikra IQS EVK.
> >
> > The M.2 variant uses the external module connected through the Key-E
> > connector instead of the onboard WCN3988 devices. Disable the onboard
> > Wi-Fi and Bluetooth nodes when the overlay is selected so the device tree
> > matches the hardware variant and does not probe the unavailable onboard
> > connectivity path.
> >
> > Describe the PCIe and UART connections through the M.2 connector, the
> > 3.3 V supply, the W_DISABLE signals and the PCIe reset signal.
> >
> > The Wi-Fi PCIe path was tested on a Shikra IQS EVK with a QCC2072
> > module. The overlay was applied, the link trained at Gen2 x1 and the
> > endpoint enumerated. Bluetooth UART and HCI runtime validation is
> > pending.
> >
> > Co-developed-by: Wei Deng <wei.deng@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Wei Deng <wei.deng@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Linghui Wu <linghui.wu@xxxxxxxxxxxxxxxx>
> > ---
> > Changes in v2:
> > - Drop regulator-boot-on and startup-delay-us from the 3.3 V regulator.
> >
> > Changes in v3:
> > - Drop the unused reg override from the disabled TC9563 node.
> >
> >   arch/arm64/boot/dts/qcom/Makefile             |   1 +
> >   .../dts/qcom/shikra-iqs-evk-m2-wifi-bt.dtso   | 105 +++++++++++++++++
> >   2 files changed, 106 insertions(+)
> >   create mode 100644 arch/arm64/boot/dts/qcom/shikra-iqs-evk-m2-wifi-bt.dtso
> >
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index 1c86e7e98f55..799faa32e2d9 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -339,6 +339,7 @@ dtb-$(CONFIG_ARCH_QCOM)     += sdx75-idp.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)        += shikra-cqm-evk.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)        += shikra-cqs-evk.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)        += shikra-iqs-evk.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)        += shikra-iqs-evk-m2-wifi-bt.dtbo
> Overlays must be applied to a base DT to test that they apply. Sashiko
> has pointed out that this doesn't apply on every version you've sent
> and you've not replied to the report. Please reply on the other
> issues.
>
> Rob