Re: [PATCH v4 13/16] ASoC: amd: acp: add ACPI machine tables for ACP7.F SoundWire

[Mukunda,Vijendar]

On 01/11/26 23:54, Pierre-Louis Bossart wrote:
> On 10/30/26 10:45, Vijendar Mukunda wrote:
>> Add amd-acp7x-acpi-match.c with four snd_soc_acpi_mach entries for
>> ACP7.F SoundWire configurations:
>> - RT721 + RT1320 on SoundWire links L0+L3
>>   (jack+dmic on RT721, spk on RT1320)
>> - RT721 + RT1320 on SoundWire links L0+L1
>>   (jack+dmic on RT721, spk on RT1320)
>> - Standalone RT721 on L0 (jack, amp and dmic endpoints)
>> - Standalone RT722 on L0 (jack, amp and dmic endpoints)
>>
>> RT721+RT1320 combo configurations use jack_dmic_endpoints for RT721,
>> skipping the internal amp since RT1320 provides amplification on a
>> dedicated SoundWire link.
> [...]
>
>> +static const struct snd_soc_acpi_adr_device rt721_l0_single_adr[] = {
>> +	{
>> +		.adr = 0x000030025d072101ull,
>> +		.num_endpoints = ARRAY_SIZE(jack_dmic_endpoints),
>> +		.endpoints = jack_dmic_endpoints,
>> +		.name_prefix = "rt721"
>> +	}
>> +};
>> +
>> +static const struct snd_soc_acpi_adr_device rt721_l0_only[] = {
>> +	{
>> +		.adr = 0x000030025d072101ull,
>> +		.num_endpoints = ARRAY_SIZE(jack_amp_dmic_endpoints),
>> +		.endpoints = jack_amp_dmic_endpoints,
>> +		.name_prefix = "rt721"
>> +	}
>> +};
> nit-pick: The naming conventions aren't self-explanatory and don't match
> the explanations above. The difference between l0_single_adr and l0_only
> are related to the endpoints used, and they don't match what's used for
> rt722 below.
Agreed. The naming is inconsistent. Will fix the naming to make the
usage clearer and post a supplemental patch.
>
> [...]> +static const struct snd_soc_acpi_adr_device
> rt722_l0_single_adr[] = {
>> +	{
>> +		.adr = 0x000030025d072201ull,
>> +		.num_endpoints = ARRAY_SIZE(jack_amp_dmic_endpoints),
>> +		.endpoints = jack_amp_dmic_endpoints,
>> +		.name_prefix = "rt722"
>> +	}
>> +};