[PATCH 2/3] alarmtimer: Return early if platform_device_register_data() fails

From: Thomas Weißschuh

Date: Mon Nov 02 2026 - 01:14:33 EST


Simplify the logic by returning on error instead of having to handle the
potential error in each following operation.

Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
---
kernel/time/alarmtimer.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c
index e60c626e326b..9ab1b053a2fb 100644
--- a/kernel/time/alarmtimer.c
+++ b/kernel/time/alarmtimer.c
@@ -89,10 +89,12 @@ static int alarmtimer_rtc_add_device(struct device *dev)

pdev = platform_device_register_data(dev, "alarmtimer",
PLATFORM_DEVID_AUTO, NULL, 0);
- if (!IS_ERR(pdev))
- device_init_wakeup(&pdev->dev, true);
+ if (IS_ERR(pdev))
+ return PTR_ERR(pdev);

- if (!IS_ERR(pdev) && try_module_get(rtc->owner)) {
+ device_init_wakeup(&pdev->dev, true);
+
+ if (try_module_get(rtc->owner)) {
WRITE_ONCE(rtcdev, rtc);
/* hold a reference so it doesn't go away */
get_device(dev);

--
2.56.0