Re: [PATCH v2 2/2] iio: adc: add driver for Texas Instruments TLA2528 adc
From: Rodolfo Giometti
Date: Mon Nov 02 2026 - 02:37:52 EST
On 01/11/2026 00:48, Jonathan Cameron wrote:
> I'd also like to avoid propagating the fallback to all channels
> if none are specified. In this particular case it is problematic
> because if you add the GPIO mode, for chips like this, we tend
> to expose all pins that aren't in use for anything else as GPIOs.
> With the fallback scheme you have no way to tell if you want all
> pins as GPIOs.
Agreed. With only 8 pins, listing the channels explicitly in the DT
costs little, and it keeps the door open for the GPIO support.
Maxime, if you drop the fallback, I think the commit message of patch
1/2 should lose its last sentence too ("If no ADC chan description is
represented, all channels will be exposed as analog inputs."), since
it would no longer describe what the driver does.
Thanks,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@xxxxxxxxxxxx
Linux Device Driver giometti@xxxxxxxx
Embedded Systems phone: +39 349 2432127
UNIX programming