Re: [PATCH 0/3] lib: Add software mul/div helpers and use them from nios2
From: Arnd Bergmann
Date: Mon Nov 02 2026 - 02:47:22 EST
On Mon, Nov 2, 2026, at 07:48, Simon Schuster wrote:
>
> thank you for your comments!
>
> On Fri, Oct 30, 2026 at 05:50:58PM +0100, Arnd Bergmann wrote:
>> Just a few minor things that stood out:
>>
>> - I don't see a need to add the files under arch/ first and then
>> move them to lib/, just start with the added files there
>
> This is an artifact of (1) not wanting to touch or drop Dinh's patch
> after picking it up and (2) being quite contend with someone with a
> current Altera affiliation doing the initial Sign-off on that check in,
> (even though this is, of course, not strictly required by license); if
> you don't mind to much, I'd prefer to leave it that way?
I think it would be ideal if you adapt Dinh's patch to just add
the files into lib/ instead of arch/nios2/: the Signoff is for
the content of the files regardless of the location.
If you still want to keep it as two patches, we can of course work
with that as well, it just makes the git history a little confusing.
Arnd