Re: [PATCH v4 03/25] accel/qda: Add compute context bank devices

From: Krzysztof Kozlowski

Date: Mon Nov 02 2026 - 03:43:59 EST


On 01/11/2026 23:21, Ekansh Gupta wrote:
> diff --git a/drivers/accel/qda/qda_rpmsg.c b/drivers/accel/qda/qda_rpmsg.c
> index 6bd977e8d68a..78b5f31974c1 100644
> --- a/drivers/accel/qda/qda_rpmsg.c
> +++ b/drivers/accel/qda/qda_rpmsg.c
> @@ -5,18 +5,18 @@
> #include <linux/rpmsg.h>
> #include <drm/drm_print.h>
>
> +#include "qda_cb.h"
> #include "qda_drv.h"
> +#include "qda_soc.h"
>
> /*
> * Both compatibles the binding defines are matched here. The glymur, hawi,
> * maili and nord nodes name "qcom,kaanapali-fastrpc" as their fallback
> - * compatible and so are matched by that entry. Per-SoC DSP parameters are
> - * attached as match data by a later patch, once there is something that
> - * consumes them.

You just added this in previous commit. Why adding invalid
documentation, which is immediately removed?

> + * compatible and so are matched by that entry.



Best regards,
Krzysztof