Re: [PATCH v4 16/25] accel/qda: Add DSP process creation and release to the legacy shim

[Krzysztof Kozlowski]

On 01/11/2026 23:21, Ekansh Gupta wrote:
>  	snode->sdev = sdev;
> +	snode->secure = secure;
>  	snode->miscdev.minor = MISC_DYNAMIC_MINOR;
>  	snode->miscdev.name = snode->name;
>  	snode->miscdev.fops = &qda_shim_fops;
> @@ -293,8 +346,6 @@ static int qda_shim_probe(struct auxiliary_device *auxdev,
>  			  const struct auxiliary_device_id *id)
>  {
>  	struct qda_dev *qdev = dev_get_platdata(&auxdev->dev);
> -	bool secure_channel = !of_property_read_bool(qdev->dev->of_node,
> -						     "qcom,non-secure-domain");

You just added these lines two patches earlier.

You are adding COMPLETELY new driver, so adding completely new code and
then removing it is confusing. It means you added something which was
not needed.


Best regards,
Krzysztof