Re: [PATCH v4 21/25] accel/qda: Add Audio protection domain attach and its remote heap

[Krzysztof Kozlowski]

On 01/11/2026 23:21, Ekansh Gupta wrote:
>  
> +/*
> + * The Audio PD keeps the remote heap across daemon restarts, so only the first
> + * attach on a device hands it to the DSP. The lock is held across the attach
> + * so that a concurrent one cannot skip the heap while the first is still in
> + * flight, and the flag is set only once the DSP has accepted it.
> + */
> +static int qda_attach_audio_pd(struct qda_session *session, struct drm_qda_remote_attach *args)
> +{
> +	struct qda_dev *qdev = session->qda_dev;
> +	struct qda_static_pd_args sargs = {};
> +	char *name;
> +	int err;
> +
> +	if (strcmp(qdev->dsp_name, "adsp") || !qdev->remote_heap_size)

That's value from DTB, so where did you document the ABI?

I see such undocumented ABI in multiple places. Usually requirement
would be to document it, but not label. Why label 'ADSP' is not correct?
Why "Audio DSP" would not be correct?

Drop all this label dependency, completely (and do not introduce other
names, like node name).


Best regards,
Krzysztof