Re: [PATCH] media: qcom: camss: select GENERIC_PHY_MIPI_DPHY
From: Loic Poulain
Date: Mon Nov 02 2026 - 03:55:58 EST
On Mon, Nov 2, 2026 at 7:58 AM Shuai Liu <847807867@xxxxxx> wrote:
>
> Commit 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API
> devices") added a call to phy_mipi_dphy_get_default_config_for_hsclk()
> in camss-csiphy.c but did not select GENERIC_PHY_MIPI_DPHY, the
> invisible bool gating phy-core-mipi-dphy.c where that helper lives.
>
> With CONFIG_VIDEO_QCOM_CAMSS=y and no other driver pulling in
> GENERIC_PHY_MIPI_DPHY, the build fails at link time:
>
> camss-csiphy.c:(.text+0x51d): undefined reference to
> `phy_mipi_dphy_get_default_config_for_hsclk'
>
> Select GENERIC_PHY_MIPI_DPHY, matching the other MIPI D-PHY consumers
> such as rkisp1, mali-c55, cadence-csi2rx and sun6i-mipi-csi2.
>
> Fixes: 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API devices")
> Signed-off-by: Shuai Liu <847807867@xxxxxx>
> ---
> drivers/media/platform/qcom/camss/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/qcom/camss/Kconfig b/drivers/media/platform/qcom/camss/Kconfig
> index b51745c942c9..b18ae4405502 100644
> --- a/drivers/media/platform/qcom/camss/Kconfig
> +++ b/drivers/media/platform/qcom/camss/Kconfig
> @@ -8,4 +8,5 @@ config VIDEO_QCOM_CAMSS
> select VIDEOBUF2_DMA_SG
> select V4L2_FWNODE
> select GENERIC_PHY
> + select GENERIC_PHY_MIPI_DPHY
So do we still need to select GENERIC_PHY?
> imply PHY_QCOM_MIPI_CSI2
> --
> 2.43.0
>