Re: [PATCH v23 01/15] dt-bindings: phy: qcom,x1e80100-csi2-phy: Add Kaanapali CSI2 PHY

[Hangxiang Ma]

On 10/31/2026 7:42 PM, Vladimir Zapolskiy wrote:
> On 10/28/26 17:20, Hangxiang Ma wrote:
> > The Kaanapali CSI2 PHY is compatible with the existing x1e80100 CSI2
> > C-PHY/DPHY binding. Add the "qcom,kaanapali-csi2-phy" compatible.
>
> Wrong, it is NOT compatible.
>
> Due to the functional difference in the register offset, which is
> described in the patch 0002, it is NOT possible to fallback to
> "qcom,x1e80100-csi2-phy" compatible device driver, and there shall
> be a new stand-alone compatible variable "qcom,kaanapali-csi2-phy".
>
> > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Hangxiang Ma <hangxiang.ma@xxxxxxxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml | 
> > 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2- 
> > phy.yaml b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2- 
> > phy.yaml
> > index 1f1e2a4993b2..6e9eb8e265df 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml
> > @@ -17,7 +17,9 @@ description:
> >   properties:
> >     compatible:
> >       oneOf:
> > -      - const: qcom,x1e80100-csi2-phy
> > +      - enum:
> > +          - qcom,kaanapali-csi2-phy
> > +          - qcom,x1e80100-csi2-phy
> >         - items:
> >             - const: qcom,glymur-csi2-phy
> >             - const: qcom,x1e80100-csi2-phy

Agree. Thanks. This line of description is stale. The commit description 
doesn't reflect the content precisely. Actually, KNP uses its own 
configuration. We notice that register offset difference so that the 
adapter macro is introduced to handle that.

<https://lore.kernel.org/all/20261028-kaanapali-camss-v23-2-95f250b18612@xxxxxxxxxxxxxxxx/>

---
Best Regards,
Hangxiang