Re: [PATCH] ksmbd: grant a POSIX ACL group entry only to the group's members

From: Namjae Jeon

Date: Mon Nov 02 2026 - 04:28:47 EST


On Mon, Nov 2, 2026 at 2:14 PM Ian Bridges <icb@xxxxxxxxxxxx> wrote:
>
> When no ACE of the DACL matches the caller, Everyone or Authenticated
> Users, smb_check_perm_dacl() falls back to the file's POSIX ACL. It
> takes the first ACL_USER or ACL_GROUP entry whose id equals the
> caller's uid. For ACL_GROUP, this compares a gid with the caller's uid.
> A numerical match grants the group's permissions even when the caller
> is not a member.
>
> Match a group entry only when the caller is also in the group.
>
> Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
> Reported-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>
> Closes: https://lore.kernel.org/linux-cifs/CAKYAXd93czbFD=znZUq_pJLXzDR5N3zc_auvAGWT7pzKR1f9Ag@xxxxxxxxxxxxxx/
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Ian Bridges <icb@xxxxxxxxxxxx>
Applied it to #ksmbd-for-next.
Thanks!