Re: [PATCH v8 0/5] Input: support for STM FTS5

[David Heidelberg]

On 02/11/2026 04:18, Dmitry Torokhov wrote:
> Hi David,
>
> On Fri, Sep 25, 2026 at 11:22:18PM +0200, David Heidelberg wrote:
> > Used on various phones. Minimal viable driver.
> >
> > Includes device-tree enabling touchscreen on Pixel 3.
> > Also, tested on Xiaomi Mi 8 (device-tree is not yet inside the mainline).
>
> I applied patches 1 through 4 (leaving patch 5/5 for the Qualcomm SoC
> tree) with a few small adjustments folded in:
>
>   - In patch 1/5, added a missing trailing newline to the reset timeout
>     error message and fixed a typo in the comment in stmfts_power_on().
>   - In patch 3/5, wrapped "const: st,stmfts5" under "contains:" in the
>     allOf condition so the check keeps working if a fallback compatible
>     is added later.
>   - In patch 4/5:
>     - moved ABS_MT_TOOL_TYPE setup from stmfts_setup_input() to
>       stmfts5_setup_input() since FTS4 does not report tool types;
>     - dropped the undocumented "stylus-enabled" property check so stylus
>       contacts unconditionally report MT_TOOL_PEN;
>     - checked X and Y resolutions independently before applying the
>       10 units/mm fallback;
>     - added a check for !sdata->ops in stmfts_probe();
>     - fixed the GPIO name in the "mode-switch" error message and a couple
>       of minor comment/log formatting nits.
>
> I will also send out a few separate follow-up patches shortly: one
> teaching touchscreen_parse_properties() to parse touchscreen-x-mm and
> touchscreen-y-mm directly so drivers do not have to open-code resolution
> handling, plus a few fixes in stmfts (not aborting FIFO parsing early on
> non-touch events, validating the 4-bit slot ID against
> STMFTS_MAX_FINGERS, and switching coordinate reporting to
> touchscreen_report_pos() so axis inversion and swapping properties are
> honored).

Hello Dmitry.

Thank you so much for improvements and merging stmfts5, I'll pick up the patches 
back to my sdm845 tree so we can apply followup improvements easily :)

David

> Thanks.